From 3b3b28b43183d07411183a6e14f1ac97579273f4 Mon Sep 17 00:00:00 2001 From: ferhat elmas Date: Mon, 13 Oct 2025 18:16:09 +0200 Subject: [PATCH 1/2] refactor: no semaphore if canceled Signed-off-by: ferhat elmas --- pkg/goanalysis/runner_loadingpackage.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pkg/goanalysis/runner_loadingpackage.go b/pkg/goanalysis/runner_loadingpackage.go index aefcf69f6b70..f904f1238e19 100644 --- a/pkg/goanalysis/runner_loadingpackage.go +++ b/pkg/goanalysis/runner_loadingpackage.go @@ -63,15 +63,11 @@ func (lp *loadingPackage) analyzeRecursive(ctx context.Context, cancel context.C } func (lp *loadingPackage) analyze(ctx context.Context, cancel context.CancelFunc, loadMode LoadMode, loadSem chan struct{}) { - loadSem <- struct{}{} - defer func() { - <-loadSem - }() - select { case <-ctx.Done(): return - default: + case loadSem <- struct{}{}: + defer func() { <-loadSem }() } // Save memory on unused more fields. From dcb4431744d7ee39180ce14165dd9def47115b9f Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Mon, 13 Oct 2025 18:25:33 +0200 Subject: [PATCH 2/2] review --- pkg/goanalysis/runner_loadingpackage.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/goanalysis/runner_loadingpackage.go b/pkg/goanalysis/runner_loadingpackage.go index f904f1238e19..217803bba744 100644 --- a/pkg/goanalysis/runner_loadingpackage.go +++ b/pkg/goanalysis/runner_loadingpackage.go @@ -67,7 +67,9 @@ func (lp *loadingPackage) analyze(ctx context.Context, cancel context.CancelFunc case <-ctx.Done(): return case loadSem <- struct{}{}: - defer func() { <-loadSem }() + defer func() { + <-loadSem + }() } // Save memory on unused more fields.