Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-types): enhanced data types #250

Merged
merged 2 commits into from Nov 21, 2019
Merged

feat(data-types): enhanced data types #250

merged 2 commits into from Nov 21, 2019

Conversation

@goldcaddy77
Copy link
Owner

goldcaddy77 commented Nov 17, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #250 into master will decrease coverage by 1.13%.
The diff coverage is 80.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   90.98%   89.84%   -1.14%     
==========================================
  Files          70       74       +4     
  Lines        1464     1527      +63     
  Branches      271      290      +19     
==========================================
+ Hits         1332     1372      +40     
- Misses        132      155      +23
Flag Coverage Δ
#backend 89.84% <80.98%> (-1.14%) ⬇️
Impacted Files Coverage Δ
src/torm/index.ts 100% <ø> (ø) ⬆️
src/metadata/metadata-storage.ts 86.04% <ø> (ø) ⬆️
src/decorators/CustomField.ts 100% <100%> (ø)
src/gql/binding.ts 93.65% <100%> (ø) ⬆️
src/decorators/BooleanField.ts 100% <100%> (ø) ⬆️
src/decorators/StringField.ts 88.46% <100%> (ø) ⬆️
src/decorators/IdField.ts 100% <100%> (ø) ⬆️
src/schema/index.ts 100% <100%> (ø) ⬆️
src/decorators/FloatField.ts 100% <100%> (ø) ⬆️
src/decorators/IntField.ts 100% <100%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc69570...3353888. Read the comment docs.

idField_eq: ID
idField_in: [ID!]
intDefaultField_eq: Float

This comment has been minimized.

Copy link
@goldcaddy77

goldcaddy77 Nov 17, 2019

Author Owner

All of these Int fields should map to Int

@goldcaddy77 goldcaddy77 force-pushed the enhanced-data-types branch 2 times, most recently from 557719c to 70463fd Nov 17, 2019
@goldcaddy77 goldcaddy77 force-pushed the enhanced-data-types branch from 70463fd to b4ca298 Nov 17, 2019
@@ -0,0 +1,9 @@
import { ColumnMetadata, decoratorDefaults, getMetadataStorage, FieldType } from '../metadata';

This comment has been minimized.

Copy link
@goldcaddy77

goldcaddy77 Nov 18, 2019

Author Owner

Todo: change this to WarthogFieldMeta

@goldcaddy77 goldcaddy77 force-pushed the enhanced-data-types branch 3 times, most recently from 1b72732 to a77ed97 Nov 21, 2019
@goldcaddy77 goldcaddy77 force-pushed the enhanced-data-types branch from a77ed97 to 3353888 Nov 21, 2019
@goldcaddy77 goldcaddy77 merged commit 4c7b818 into master Nov 21, 2019
1 of 3 checks passed
1 of 3 checks passed
codecov/patch 80.98% of diff hit (target 90.98%)
Details
codecov/project 89.84% (-1.14%) compared to bc69570
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@goldcaddy77 goldcaddy77 deleted the enhanced-data-types branch Nov 21, 2019
@goldcaddy77

This comment has been minimized.

Copy link
Owner Author

goldcaddy77 commented Nov 21, 2019

🎉 This PR is included in version 1.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.