New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title attribute of tab does not exist in dragproxy tab #107

Closed
sholybonoly opened this Issue May 15, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@sholybonoly
Contributor

sholybonoly commented May 15, 2016

The drag proxy version of a tab is not the same as when it exists in the layout. Specifically we have a title attribute is not set. Therefore any styling on tab based on this can not be applied when tab is being dragged.

sholybonoly added a commit to sholybonoly/golden-layout that referenced this issue May 15, 2016

mattgodbolt added a commit that referenced this issue Sep 22, 2016

Merge pull request #108 from sholybonoly/fix-#107
Fix for #107 Set title attribute on tab to match lm_tab in main layout.
@mattgodbolt

This comment has been minimized.

Show comment
Hide comment
@mattgodbolt

mattgodbolt Sep 22, 2016

Collaborator

Fixed with the merge of ee0c872

Collaborator

mattgodbolt commented Sep 22, 2016

Fixed with the merge of ee0c872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment