New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsMoveable item #13

Closed
franck34 opened this Issue Nov 4, 2014 · 6 comments

Comments

Projects
None yet
5 participants
@franck34

franck34 commented Nov 4, 2014

Hi

Should be great if we can decide that an item is moveable or not, like isCloseable.

Cheers !

@iver56

This comment has been minimized.

Show comment
Hide comment
@iver56

iver56 Nov 5, 2014

Contributor

I agree. That would make me able to fix the problem in the following scenario:

I have three tabs with isClosable = false. I can, however, drag one of the tabs so it becomes a row or a column. I can close that row (or column), and that makes the tab go away, even if it has isClosable = false. The layout is now in an "inconsistent" state.

Contributor

iver56 commented Nov 5, 2014

I agree. That would make me able to fix the problem in the following scenario:

I have three tabs with isClosable = false. I can, however, drag one of the tabs so it becomes a row or a column. I can close that row (or column), and that makes the tab go away, even if it has isClosable = false. The layout is now in an "inconsistent" state.

@eviltik

This comment has been minimized.

Show comment
Hide comment
@eviltik

eviltik Nov 6, 2014

@iver56 can you open another ticket for isClosable = false please ? i already got a codepen to reproduce

eviltik commented Nov 6, 2014

@iver56 can you open another ticket for isClosable = false please ? i already got a codepen to reproduce

@WolframHempel

This comment has been minimized.

Show comment
Hide comment
@WolframHempel

WolframHempel Nov 6, 2014

Collaborator

Cheers, I'm convinced :-). isMovable should be a part of the next release. (But will be called reorderEnabled to be consistent with the global property that has the same effect)

Collaborator

WolframHempel commented Nov 6, 2014

Cheers, I'm convinced :-). isMovable should be a part of the next release. (But will be called reorderEnabled to be consistent with the global property that has the same effect)

@eviltik

This comment has been minimized.

Show comment
Hide comment
@eviltik

eviltik commented Nov 6, 2014

+1

@iver56

This comment has been minimized.

Show comment
Hide comment
@iver56

iver56 Nov 10, 2014

Contributor

@eviltik Done! #17

Contributor

iver56 commented Nov 10, 2014

@eviltik Done! #17

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Nov 17, 2014

Contributor

Release 1.0.5 introduces reorderEnabled: true on an item level. Please reopen this issue if this doesn't satisfy your usecase.

Contributor

ghost commented Nov 17, 2014

Release 1.0.5 introduces reorderEnabled: true on an item level. Please reopen this issue if this doesn't satisfy your usecase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment