Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-integral chrome zooms cause layout issues #137

Closed
mattgodbolt opened this issue Sep 17, 2016 · 0 comments
Closed

Non-integral chrome zooms cause layout issues #137

mattgodbolt opened this issue Sep 17, 2016 · 0 comments

Comments

@mattgodbolt
Copy link
Collaborator

@mattgodbolt mattgodbolt commented Sep 17, 2016

If one has a two column layout and then uses Chrome browser zoom, under some circumstances the rounding/extra pixel allocation process adds an extra pixel, meaning the rightmost column in a row word-wraps off underneath and essentially vanishes.

Debugging, this is because the width() or height() in _setAbsoluteSizes in RowOrColumn.js returns a non-integral value. Later on, this means additionalPixel is also non-integral, leading to an extra pixel being given out in if contentItem loops.

I tried to write a test to reproduce it, but under normal circumstances one can't create a non-integral-sized element. I have a patch coming for the fix though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant