New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery Version mismatch between Bower and NPM packages #44

Closed
nkoterba opened this Issue Mar 12, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@nkoterba
Contributor

nkoterba commented Mar 12, 2015

Also, not sure if you want to use latest jQuery for Bower.json unless you're planning to stay on top of any breaking changes in latest jQuery. Could use ~2.1.3 for Bower and ^2.1.3 for NPM.

Package.Json
https://github.com/hoxton-one/golden-layout/blob/master/package.json#L27-29

  "dependencies": {
    "jquery": "2.1.1"
  },

Bower.json

  "dependencies": {
    "jquery": "latest"
  },

https://github.com/hoxton-one/golden-layout/blob/master/bower.json#L23-25

@ksatokcc

This comment has been minimized.

Show comment
Hide comment
@ksatokcc

ksatokcc Jul 6, 2016

The dependency on the latest jquery is causing problems in Bower.json - other javascript libraries we are using have lower jQuery dependencies. Can you please change the Bower.json dependency to 2.1.1?

ksatokcc commented Jul 6, 2016

The dependency on the latest jquery is causing problems in Bower.json - other javascript libraries we are using have lower jQuery dependencies. Can you please change the Bower.json dependency to 2.1.1?

@mattgodbolt

This comment has been minimized.

Show comment
Hide comment
@mattgodbolt

mattgodbolt Sep 21, 2016

Collaborator

Do you still need this change? Both the package.json and bower.json use jquery: * now, which I believe fixes this issue.

Collaborator

mattgodbolt commented Sep 21, 2016

Do you still need this change? Both the package.json and bower.json use jquery: * now, which I believe fixes this issue.

@ksatokcc

This comment has been minimized.

Show comment
Hide comment
@ksatokcc

ksatokcc Sep 21, 2016

Great, thank you!

From: Matt Godbolt [mailto:notifications@github.com]
Sent: Wednesday, September 21, 2016 4:53 AM
To: deepstreamIO/golden-layout
Cc: Kristine Sato; Comment
Subject: Re: [deepstreamIO/golden-layout] jQuery Version mismatch between Bower and NPM packages (#44)

Do you still need this change? Both the package.json and bower.json use jquery: * now, which I believe fixes this issue.


You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/golden-layout/golden-layout/issues/44#issuecomment-248589145, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADWkQTBCRCJrTfDS7Am0xOGZo7D280veks5qsRqzgaJpZM4Dt8x0.


Please visit the following website to read the KCC legal notice:
http://www.kccllc.com/Email-Disclaimer/


ksatokcc commented Sep 21, 2016

Great, thank you!

From: Matt Godbolt [mailto:notifications@github.com]
Sent: Wednesday, September 21, 2016 4:53 AM
To: deepstreamIO/golden-layout
Cc: Kristine Sato; Comment
Subject: Re: [deepstreamIO/golden-layout] jQuery Version mismatch between Bower and NPM packages (#44)

Do you still need this change? Both the package.json and bower.json use jquery: * now, which I believe fixes this issue.


You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/golden-layout/golden-layout/issues/44#issuecomment-248589145, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADWkQTBCRCJrTfDS7Am0xOGZo7D280veks5qsRqzgaJpZM4Dt8x0.


Please visit the following website to read the KCC legal notice:
http://www.kccllc.com/Email-Disclaimer/


@nkoterba

This comment has been minimized.

Show comment
Hide comment
@nkoterba

nkoterba Sep 22, 2016

Contributor

I haven't encountered any jQuery issues to date with Golden layout (in other words, everything seems to be working ok with my current build/run setup), so I will close this.

Contributor

nkoterba commented Sep 22, 2016

I haven't encountered any jQuery issues to date with Golden layout (in other words, everything seems to be working ok with my current build/run setup), so I will close this.

@nkoterba nkoterba closed this Sep 22, 2016

@mattgodbolt

This comment has been minimized.

Show comment
Hide comment
@mattgodbolt

mattgodbolt Sep 22, 2016

Collaborator

Thanks!
On Thu, Sep 22, 2016 at 6:45 AM, nkoterba notifications@github.com wrote:

Closed #44 #44.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#44 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmsdfGT5euhbNlwJI3CM9RZT6IIouNEks5qsmpbgaJpZM4Dt8x0
.

Collaborator

mattgodbolt commented Sep 22, 2016

Thanks!
On Thu, Sep 22, 2016 at 6:45 AM, nkoterba notifications@github.com wrote:

Closed #44 #44.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#44 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAmsdfGT5euhbNlwJI3CM9RZT6IIouNEks5qsmpbgaJpZM4Dt8x0
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment