New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React component type is not recognised by createContentItem #87

Closed
evansb opened this Issue Apr 13, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@evansb
Contributor

evansb commented Apr 13, 2016

The following example in the documentation does not work in 1.5.0

myLayout.root.contentItems[ 0 ].addChild({
    type:'react-component',
    component: 'testComponent',
    props: { label: 'X' }
});

It produces this error

goldenlayout.js?e452:766 Uncaught Configuration Error: Unknown type 'react-component'. Valid types are column,row,stack,component

evansb referenced this issue in evansb/golden-layout Apr 13, 2016

Evan Sebastian
Merge pull request #1 from evansb/fix-#87
Handles React component in createContentItem

@WolframHempel WolframHempel closed this in #89 Apr 15, 2016

WolframHempel referenced this issue Apr 15, 2016

Merge pull request #89 from evansb/fix-#87
Handles React component in createContentItem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment