Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed three sources of memory leaks when destroying the LayoutManager #119

Merged
merged 3 commits into from Sep 22, 2016

Conversation

@pmalouin
Copy link

@pmalouin pmalouin commented Jul 20, 2016

I first saw that repeatedly creating and destroying a LayoutManager object made the heap memory size grow over time. I did some investigation using heap snapshots and found that some DOM events were not unsubscribed when destroying the LayoutManager. This pull request fixes three cases that I have been able to locate.

After these three changes, memory does not seem to grow as much anymore and there is no more detached DOM tree in the heap snapshots.

Thanks for this great library!

@WolframHempel
Copy link
Collaborator

@WolframHempel WolframHempel commented Sep 12, 2016

Hi @pmalouin , thank you for your pull request and sorry for the delay.

I was wondering: I have started running a tech startup (deepstream.io/deepstreamhub) a few month ago and it is a crazy amount of work. As a result, I can't help but neglect GoldenLayout and pull requests are piling up.

It's a good and widely used project and I wouldn't want to see it die. Would you be interested in becoming a maintainer (be elevated to "admin", curate the project etc.)? Happy to promote/ announce your role in any way you wish.

@pmalouin
Copy link
Author

@pmalouin pmalouin commented Sep 14, 2016

Hi @WolframHempel , thanks for your proposal! I can't commit too much time for the project. Do you have expectations? If you're open that I contribute now and then, I'd be glad to give a hand.

@mattgodbolt
Copy link
Collaborator

@mattgodbolt mattgodbolt commented Sep 22, 2016

Hi @pmalouin : I'm happy to add you if you have any time to spend, but I'm also going to merge your patch now (I'm picking up on the project for now). Let me know :), and thank you for your submission!

@mattgodbolt mattgodbolt merged commit d56cf73 into golden-layout:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants