Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed three sources of memory leaks when destroying the LayoutManager #119
I first saw that repeatedly creating and destroying a LayoutManager object made the heap memory size grow over time. I did some investigation using heap snapshots and found that some DOM events were not unsubscribed when destroying the LayoutManager. This pull request fixes three cases that I have been able to locate.
After these three changes, memory does not seem to grow as much anymore and there is no more detached DOM tree in the heap snapshots.
Thanks for this great library!
Hi @pmalouin , thank you for your pull request and sorry for the delay.
I was wondering: I have started running a tech startup (deepstream.io/deepstreamhub) a few month ago and it is a crazy amount of work. As a result, I can't help but neglect GoldenLayout and pull requests are piling up.
It's a good and widely used project and I wouldn't want to see it die. Would you be interested in becoming a maintainer (be elevated to "admin", curate the project etc.)? Happy to promote/ announce your role in any way you wish.