Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a showed event #124

Merged
merged 5 commits into from Sep 22, 2016
Merged

add a showed event #124

merged 5 commits into from Sep 22, 2016

Conversation

@bkrrrr
Copy link
Contributor

@bkrrrr bkrrrr commented Aug 11, 2016

it is called after show and is super helpful for some visualizations, which
need a visible container to make a correct size computation. Like SVG/D3
implementations.

bkrrrr added 5 commits Aug 11, 2016
it is called after show and is super helpful for some visualizations,who
need a visible container to make a correct size computation. Like SVG/D3
implementations.
This reverts commit c8b085a.
@mattgodbolt mattgodbolt merged commit 55a77c6 into golden-layout:master Sep 22, 2016
@mattgodbolt
Copy link
Collaborator

@mattgodbolt mattgodbolt commented Sep 22, 2016

Many thanks for this. I've merged (with tests added). I renamed 'showed' to 'shown' as that seemed to be more grammatically correct. Hope that's not going to cause issues!

@bkrrrr
Copy link
Contributor Author

@bkrrrr bkrrrr commented Sep 23, 2016

No really :). It`s from on naming convention for events, like "before,
during, after". No sure, in which language i picked that up.

  • show
  • showing
  • showed
  • delete
  • deleting
  • deleted

Anyways, cool. thank you for merging.

On Thu, Sep 22, 2016 at 2:52 AM, Matt Godbolt notifications@github.com
wrote:

Many thanks for this. I've merged (with tests added). I renamed 'showed'
to 'shown' as that seemed to be more grammatically correct. Hope that's not
going to cause issues!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#124 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANprRqdIrXTXXD1E-b54muzAkgn3qeVJks5qsdEwgaJpZM4JihuL
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants