Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for individual item minimum size #130

Merged
merged 2 commits into from
Sep 22, 2016

Conversation

joafalves
Copy link

You can now add minWidth and minHeight to each individual item configuration and the dragging will behave as requested.

@joafalves
Copy link
Author

Btw, you can ignore the release commit, it was merged by mistake :)

@WolframHempel
Copy link
Collaborator

Hi @whitebeard86, thank you for your pull request.

I was wondering: I have started running a tech startup (deepstream.io/deepstreamhub) a few month ago and it is a crazy amount of work. As a result, I can't help but neglect GoldenLayout and pull requests are piling up.

It's a good and widely used project and I wouldn't want to see it die. Would you be interested in becoming a maintainer (be elevated to "admin", curate the project etc.)? Happy to promote/ announce your role in any way you wish.

@joafalves
Copy link
Author

joafalves commented Sep 12, 2016

Hello,

That would be fine by me, we are using this project massively in our own stack so giving it some maintenance is already my task in the forked version, I accept :)

Btw, you can take a look at our Golden Layout usage here:
https://scontent-frt3-1.xx.fbcdn.net/t31.0-8/14206091_554782471387038_7109704314382706765_o.jpg

(we are building the Scarlett Game Studio)

@mattgodbolt
Copy link
Contributor

I'm happy to merge this in too (I just spent a bunch of time automating tests, see the travis-ci link in the README for a continuous build); if you do become an admin I'd appreciate feedback on the setup (I'm on Linux so might be inadvertently breaking Windows builds etc)

@mattgodbolt mattgodbolt merged commit d89b30d into golden-layout:master Sep 22, 2016
@mattgodbolt
Copy link
Contributor

Merged: will shortly build and release 1.5.4 and would appreciate you testing; please reopen if you have further issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants