New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly check for __glMaxmised #31

Merged
merged 1 commit into from Feb 15, 2015

Conversation

Projects
None yet
3 participants
@bmuenzenmeyer
Contributor

bmuenzenmeyer commented Jan 19, 2015

From what I can tell on Line 191 you need to check for __glMaximised here.

Changing to the proposed conditional resolved an issue for me when setting up goldenlayout from a serialized config.

Brian Muenzenmeyer
Update LayoutManager.js
From what I can tell on Line 191 you need to check for __glMaximised here. 

Changing to the proposed conditional resolved an issue for me when setting up goldenlayout from a serialized config.

@bmuenzenmeyer bmuenzenmeyer changed the title from Update LayoutManager.js to Explicitly check for __glMaxmised Jan 19, 2015

@steelsojka

This comment has been minimized.

Show comment
Hide comment
@steelsojka

steelsojka Feb 13, 2015

Contributor

+1

Contributor

steelsojka commented Feb 13, 2015

+1

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Feb 15, 2015

Contributor

Good spot, thank you very much

Contributor

ghost commented Feb 15, 2015

Good spot, thank you very much

deepstreamIO pushed a commit that referenced this pull request Feb 15, 2015

hoxton-one
Merge pull request #31 from bmuenzenmeyer/patch-1
Explicitly check for __glMaxmised

@deepstreamIO deepstreamIO merged commit bdc06d9 into golden-layout:master Feb 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment