Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: cleanup: Remove ES5 codebase, port over remaining changes to ES6 codebase #564

Merged
merged 1 commit into from Feb 14, 2020

Conversation

@martin31821
Copy link
Member

martin31821 commented Feb 13, 2020

This PR serves three purposes:

  • Add the package-lock.json to make reproducible builds possible
  • Port over the existing changes to ES6 codebase and remove ES5 codebase
  • Remove the old scripts required to build ES5 codebase.

Removing the ES5 codebase relieves maintenance burden from the maintainers
team and eases up building and consuming golden-layout.

…base

This commit serves two purposes:
- Add the package-lock.json to make reproducible builds possible
- Port over the existing changes to ES6 codebase and remove ES5 codebase

Removing the ES5 codebase relieves maintenance burden from the maintainers
team and eases up building and consuming golden-layout.
@atcol
atcol approved these changes Feb 13, 2020
contentItem.emit('minimised');
this.emit('stateChanged');
}

_$cleanupBeforeMaximisedItemDestroyed() {

This comment has been minimized.

Copy link
@studyhog

studyhog Feb 13, 2020

Out of curiosity (I did some googling and couldn't really find a usage of both _ and $), what's the convention here? I know _ means private, and $ is frequently used as an alias for document.getElementById; but I'm rather new to js and have never seen the _$ prefix before. What does this mean?

Thanks so much for stepping up and maintaining this project. I'm definitely going to try and contribute as well, once I'm more familiar with js.

This comment has been minimized.

Copy link
@martin31821

martin31821 Feb 13, 2020

Author Member

underscore usually means private, protected or internal.
In the context of rxJS, $ is used to denote observables, in the context of JQuery it is often used to have jquery instances

As far as I can tell, methods prefixed with $ in golden-layout are flagged for usage with callDownwards and callUpwards

This comment has been minimized.

Copy link
@studyhog
@martin31821 martin31821 merged commit 71a61fb into master Feb 14, 2020
1 check failed
1 check failed
ci/circleci Your tests failed on CircleCI
Details
@martin31821 martin31821 deleted the cleanup/remove-es5 branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.