Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed stack overflow due to React props and wrong 'this' argument when calling 'componentWillUpdate' #92

Merged
merged 4 commits into from Apr 15, 2016

Conversation

@stephenjelfs
Copy link
Contributor

@stephenjelfs stephenjelfs commented Apr 13, 2016

Do not recursively search React props--it can easily lead to a stack
overflow: Uncaught RangeError: Maximum call stack size exceeded.

Do not recursively search React props--it can easily lead to a stack
overflow: Uncaught RangeError: Maximum call stack size exceeded.
…gument.

The original 'this' argument should also be used when calling
"_originalComponentWillUpdate()".
…gument

The original 'this' argument should also be used when calling
"_originalComponentWillUpdate()".
@stephenjelfs
Copy link
Contributor Author

@stephenjelfs stephenjelfs commented Apr 14, 2016

These commits fix two bugs:

  • a stack overflow when iterating over React properties
  • an incorrect 'this' argument when calling the original React components 'componentWillUpdate' method
@stephenjelfs stephenjelfs changed the title Fixed stack overflow due to React props Fixed stack overflow due to React props and wrong 'this' argument when calling 'componentWillUpdate' Apr 14, 2016
@WolframHempel WolframHempel merged commit f6c8677 into golden-layout:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants