Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some more encodings for online dictionaries #252

Closed
chulai opened this issue Mar 29, 2013 · 5 comments
Closed

Add some more encodings for online dictionaries #252

chulai opened this issue Mar 29, 2013 · 5 comments
Labels
Feature Request
Milestone
1.5

Comments

@chulai
Copy link
Member

chulai commented Mar 29, 2013

Program currently supports:
* %GDWORD% --> UTF-8
* %GD1251% --> Windows-1251 / CP1251
* %GDISO1% --> ISO-8859-1
* %GDISO2% --> ISO-8859-2
...
* %GDISO15% --> ISO-8859-15
* %GDISO16% --> ISO-8859-16
* %GDBIG5% --> Big-5

Qt supported text encodings: http://harmattan-dev.nokia.com/docs/platform-api-reference/xml/daily-docs/libqt4/qtextcodec.html#details

Following user is requesting additional encodings GBK (Simplified Chinese), Big 5 (Traditional Chinese) and SHIFT JIS (Japanese):
http://goldendict.org/forum/viewtopic.php?f=4&t=1864&p=7982#p7975

Change should be straightforward in WebSiteDictionary::getArticle() method in website.cc file.
Abs62 added a commit that referenced this issue Mar 30, 2013
@Abs62
Add some more encodings for online dictionaries (issue #252)
afff216 
Big5-HKSCS - %25GDBIG5HKSCS%25
GB18030 - %25GDGBK%25
Shift-JIS - %25GDSHIFTJIS%25
@chulai
Copy link
Member Author

chulai commented Mar 30, 2013

Is the name of the codec Big-5 or Big5?

@Tvangeste
Copy link
Member

@chulai Big-5 was used originally and worked fine for me and others.

@Tvangeste
Copy link
Member

Btw, we probably should update the help message in the Dictionaries -> Websites tab. Currently, only %GD1251% and %GDISO1% are mentioned there.

@chulai
Copy link
Member Author

chulai commented Mar 30, 2013

Great. So it works as a kind of alias. Yes, there is no help for other available encoding.

Abs62 added a commit that referenced this issue Mar 30, 2013
@Abs62
Enhance help string on "Websites" tab (issue #252 again)
486e694
@chulai
Copy link
Member Author

chulai commented Mar 31, 2013

Fixed

@chulai chulai closed this as completed Mar 31, 2013
hosiet pushed a commit to hosiet/goldendict that referenced this issue Dec 22, 2022
@xiaoyifang
Merge pull request goldendict#252 from xiaoyifang/fix/version-normalize
d809ca0 
change version.txt to latest git tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@Tvangeste @chulai