feat: add onSync callback to resolve #87 (#91)

* feat: add onSync callback to resolve #87 * fix: should keep updateScroll as manual trigger api * doc: update the README * simplify code Co-authored-by: Allen Yang <Goldenyz@hotmail.com>
goldenyz · Jan 30, 2020 · 755caea · 755caea
1 parent b208ee5
commit 755caea
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -79,6 +79,13 @@ All the callback 'onXXXX' can accept a parameter: the ref to the scrollbar conta
     </PerfectScrollbar>
 ```
 
+#### onSync
+Invoked when `PerfectScrollbar` comp needs to sync the scrollbar container by invoking `ps.update()`(Basically, it is invoked in CDU lifecycle) and receive the internal `perfect-scroll` instance `ps` as parameter.
+
+It is useful when you want to customize the sync logic in some scenarios, eg: debounce the invocation of `ps.update()`.
+
+For more detail, please refer to [issue#87](https://github.com/goldenyz/react-perfect-scrollbar/issues/87) and the example directory.
+
 #### React.HTMLAttributes
 Any attributes defined in [React.HTMLAttributes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L1689) can be used for the component.
 

diff --git a/example/example.js b/example/example.js
@@ -10,13 +10,22 @@ function logEvent(type) {
   console.log(`event '${type}' triggered!`);
 }
 
+const debounce = (fn, ms = 0) => {
+  let timeoutId;
+  return function wrapper(...args) {
+    clearTimeout(timeoutId);
+    timeoutId = setTimeout(() => fn.apply(this, args), ms);
+  };
+};
+
 class Example extends Component {
   constructor(props) {
     super(props);
 
     this.state = {
       className: undefined,
       onXReachEnd: null,
+      items: Array.from(new Array(100).keys()),
     };
   }
 
@@ -33,28 +42,48 @@ class Example extends Component {
     logEvent('onYReachEnd');
   }
 
+  handleTrigger = () => {
+    this.setState({
+      items: Array.from(new Array(100).keys()),
+    });
+  }
+
+  handleSync = debounce((ps) => {
+    ps.update();
+    console.log('debounce sync ps container in 1000ms');
+  }, 1000)
+
   render() {
     const { className, onXReachEnd } = this.state;
 
     return (
-      <div className="example">
-        <ScrollBar
-          className={className}
-          onScrollY={() => logEvent('onScrollY')}
-          onScrollX={() => logEvent('onScrollX')}
-          onScrollUp={() => logEvent('onScrollUp')}
-          onScrollDown={() => logEvent('onScrollDown')}
-          onScrollLeft={() => logEvent('onScrollLeft')}
-          onScrollRight={() => logEvent('onScrollRight')}
-          onYReachStart={() => logEvent('onYReachStart')}
-          onYReachEnd={this.handleYReachEnd}
-          onXReachStart={() => logEvent('onXReachStart')}
-          onXReachEnd={onXReachEnd}
-          component="div"
-        >
-          <div className="content" />
-        </ScrollBar>
-      </div>
+      <React.Fragment>
+
+        <div className="example">
+          <ScrollBar
+            className={className}
+            onScrollY={() => logEvent('onScrollY')}
+            onScrollX={() => logEvent('onScrollX')}
+            onScrollUp={() => logEvent('onScrollUp')}
+            onScrollDown={() => logEvent('onScrollDown')}
+            onScrollLeft={() => logEvent('onScrollLeft')}
+            onScrollRight={() => logEvent('onScrollRight')}
+            onYReachStart={() => logEvent('onYReachStart')}
+            onYReachEnd={this.handleYReachEnd}
+            onXReachStart={() => logEvent('onXReachStart')}
+            onXReachEnd={onXReachEnd}
+            component="div"
+          >
+            <div className="content" />
+          </ScrollBar>
+        </div>
+        <div className="example">
+          <button onClick={this.handleTrigger}>Trigger</button>
+          <ScrollBar onSync={this.handleSync}>
+            {this.state.items.map(e => (<div key={e}>{e}</div>))}
+          </ScrollBar>
+        </div>
+      </React.Fragment>
     );
   }
 }

diff --git a/src/scrollbar.js b/src/scrollbar.js
@@ -37,7 +37,9 @@ export default class ScrollBar extends Component {
 
   componentDidUpdate(prevProps) {
     this._updateEventHook(prevProps);
-    this._ps.update();
+
+    this.updateScroll();
+
     if (prevProps.className !== this.props.className) {
       this._updateClassName();
     }
@@ -90,7 +92,7 @@ export default class ScrollBar extends Component {
   }
 
   updateScroll() {
-    this._ps.update();
+    this.props.onSync(this._ps);
   }
 
   handleRef(ref) {
@@ -116,6 +118,7 @@ export default class ScrollBar extends Component {
       onXReachStart,
       onXReachEnd,
       component,
+      onSync,
       children,
       ...remainProps
     } = this.props;
@@ -145,6 +148,7 @@ ScrollBar.defaultProps = {
   onYReachEnd: undefined,
   onXReachStart: undefined,
   onXReachEnd: undefined,
+  onSync: ps => ps.update(),
   component: 'div',
 };
 
@@ -165,5 +169,6 @@ ScrollBar.propTypes = {
   onYReachEnd: PropTypes.func,
   onXReachStart: PropTypes.func,
   onXReachEnd: PropTypes.func,
+  onSync: PropTypes.func,
   component: PropTypes.string,
 };