Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic binaries for running golem from source #1888

Merged
merged 14 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@maaktweluit
Copy link
Collaborator

commented Jan 11, 2018

Part of solving multi-os test scenarios

@maaktweluit maaktweluit self-assigned this Jan 11, 2018

@codecov

This comment has been minimized.

Copy link

commented Jan 11, 2018

Codecov Report

Merging #1888 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1888      +/-   ##
===========================================
+ Coverage    89.19%   89.27%   +0.07%     
===========================================
  Files          191      190       -1     
  Lines        17444    17378      -66     
===========================================
- Hits         15560    15514      -46     
+ Misses        1884     1864      -20

@maaktweluit maaktweluit force-pushed the maaktweluit:mwu/bins branch from 7136496 to da72e3b Oct 5, 2018

@maaktweluit maaktweluit requested a review from ederenn Oct 5, 2018

@maaktweluit maaktweluit changed the title WIP: Generic binaries for running golem from source Generic binaries for running golem from source Oct 5, 2018

@maaktweluit maaktweluit requested a review from mfranciszkiewicz Oct 5, 2018

@maaktweluit maaktweluit force-pushed the maaktweluit:mwu/bins branch from da72e3b to 5af0392 Oct 5, 2018

@ederenn

ederenn approved these changes Oct 5, 2018

Copy link

left a comment

scripts are working for me

@mfranciszkiewicz
Copy link
Collaborator

left a comment

Maybe move the PROJECT_DIR, the venv directory and source directory to a separate script? That way we could configure the environment.


call ".\golem_source__prep.bat"

echo "Intstall requirements"

This comment has been minimized.

Copy link
@mfranciszkiewicz

mfranciszkiewicz Oct 5, 2018

Collaborator

Typo :)

maaktweluit added some commits Oct 8, 2018

@maaktweluit

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 8, 2018

@mfranciszkiewicz fixed the config split in the mac version, please have a look!

Will apply to linux and mac when reviewed

@mfranciszkiewicz
Copy link
Collaborator

left a comment

Linux and macOS can be merged

Show resolved Hide resolved scripts/test_bin/mac/golem_source__prep.sh Outdated
@maaktweluit

This comment has been minimized.

Copy link
Collaborator Author

commented Oct 16, 2018

@mfranciszkiewicz Thanks for the tips, applied them all! Please check one final time, then we can merge :)

@maaktweluit maaktweluit merged commit b60834c into golemfactory:develop Oct 16, 2018

5 of 6 checks passed

buildbot/test_integrations Build done.
Details
buildbot/control_build Build done.
Details
buildbot/control_test Build done.
Details
codecov/patch Coverage not affected when comparing 67354dd...4f40334
Details
codecov/project 89.27% (+0.07%) compared to 67354dd
Details
license/cla Contributor License Agreement is signed.
Details

@maaktweluit maaktweluit deleted the maaktweluit:mwu/bins branch Oct 16, 2018

@wafflebot wafflebot bot removed the in progress label Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.