Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unburden golem.client as a sole RPC provider #3368

Merged
merged 14 commits into from Oct 8, 2018

Conversation

Projects
None yet
3 participants
@jiivan
Copy link
Contributor

commented Oct 1, 2018

  • Introduce @expose decorator for remote procedures
  • Introduce golemcli.py debug exposed_procedures for dynamic procedures mapping
  • Remove static procedures mapping file
  • Remove unused event listening logic

@wafflebot wafflebot bot added the in progress label Oct 1, 2018

@jiivan jiivan referenced this pull request Oct 1, 2018

Closed

[WIP] Concent trigger #3352

@jiivan jiivan requested review from Elfoniok and etam Oct 1, 2018

Show resolved Hide resolved golem/interface/client/terms.py Outdated
Show resolved Hide resolved golem/node.py

jiivan added some commits Oct 1, 2018

Show resolved Hide resolved golem/node.py

jiivan added some commits Oct 1, 2018

Show resolved Hide resolved golem/node.py Outdated
Show resolved Hide resolved golem/rpc/router.py
Show resolved Hide resolved golem/client.py
Show resolved Hide resolved golem/rpc/session.py
Show resolved Hide resolved golem/rpc/session.py
Show resolved Hide resolved golem/rpc/session.py
Show resolved Hide resolved golem/rpc/session.py Outdated
Show resolved Hide resolved golem/rpc/session.py Outdated
Show resolved Hide resolved golem/rpc/session.py
Show resolved Hide resolved golem/rpc/session.py Outdated
Show resolved Hide resolved golem/rpc/utils.py
Show resolved Hide resolved golem/rpc/utils.py
Show resolved Hide resolved golem/rpc/utils.py Outdated
Show resolved Hide resolved golem/node.py
@etam
Copy link
Contributor

left a comment

I like the idea! But I left some notes around...

jiivan added some commits Oct 8, 2018

@codecov

This comment has been minimized.

Copy link

commented Oct 8, 2018

Codecov Report

Merging #3368 into develop will increase coverage by 0.08%.
The diff coverage is 95.51%.

@@             Coverage Diff             @@
##           develop    #3368      +/-   ##
===========================================
+ Coverage    89.18%   89.27%   +0.08%     
===========================================
  Files          191      192       +1     
  Lines        17469    17565      +96     
===========================================
+ Hits         15580    15681     +101     
+ Misses        1889     1884       -5

jiivan added some commits Oct 8, 2018

@etam

etam approved these changes Oct 8, 2018

@jiivan jiivan merged commit 283898a into develop Oct 8, 2018

5 checks passed

buildbot/control_build Build done.
Details
buildbot/control_test Build done.
Details
codecov/patch 95.51% of diff hit (target 80%)
Details
codecov/project 89.27% (+0.08%) compared to 5a288ff
Details
license/cla Contributor License Agreement is signed.
Details

@jiivan jiivan deleted the rpc_expose branch Oct 8, 2018

@wafflebot wafflebot bot removed the in progress label Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.