Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scipy and ssim dependencies #3401

Merged
merged 5 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@maaktweluit
Copy link
Collaborator

commented Oct 8, 2018

Continue where #3332 left off

On linux the total size of golem .tar.gz went from 185mb to 116mb

inexxt added some commits Sep 20, 2018

# This is a combination of 2 commits.
# The first commit's message is:

Remove scipy requirement

# This is the 2nd commit message:

Fix test

@maaktweluit maaktweluit self-assigned this Oct 8, 2018

@wafflebot wafflebot bot added the in progress label Oct 8, 2018

@maaktweluit maaktweluit changed the title Mwu/rem scipy Remove scipy and ssc Oct 8, 2018

@maaktweluit maaktweluit changed the title Remove scipy and ssc Remove scipy and ssim dependencies Oct 8, 2018

@codecov

This comment has been minimized.

Copy link

commented Oct 8, 2018

Codecov Report

Merging #3401 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3401      +/-   ##
===========================================
- Coverage     89.3%   89.27%   -0.03%     
===========================================
  Files          192      192              
  Lines        17565    17564       -1     
===========================================
- Hits         15686    15681       -5     
- Misses        1879     1883       +4

@maaktweluit maaktweluit merged commit b1f9e63 into develop Oct 9, 2018

5 checks passed

buildbot/control_build Build done.
Details
buildbot/control_test Build done.
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +10.69% compared to 283898a
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the in progress label Oct 9, 2018

@maaktweluit maaktweluit deleted the mwu/rem-scipy branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.