Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of preferred geth nodes #3579

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@Krigpl
Copy link
Contributor

commented Nov 20, 2018

We assume that the list of addresses is ordered by preference (i.e. last address is the least preferred), but the traversal order was reversed.

@Krigpl Krigpl requested a review from mfranciszkiewicz Nov 20, 2018

@wafflebot wafflebot bot added the in progress label Nov 20, 2018

@codecov

This comment has been minimized.

Copy link

commented Nov 20, 2018

Codecov Report

Merging #3579 into develop will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3579      +/-   ##
===========================================
- Coverage    89.75%   89.72%   -0.03%     
===========================================
  Files          194      194              
  Lines        17617    17617              
===========================================
- Hits         15812    15807       -5     
- Misses        1805     1810       +5

@mfranciszkiewicz mfranciszkiewicz merged commit ccde841 into develop Nov 21, 2018

5 of 6 checks passed

buildbot/test_integrations Build done.
Details
buildbot/control_build Build done.
Details
buildbot/control_test Build done.
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +10.24% compared to e422d05
Details
license/cla Contributor License Agreement is signed.
Details

@mfranciszkiewicz mfranciszkiewicz deleted the geth_order branch Nov 21, 2018

@wafflebot wafflebot bot removed the in progress label Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.