Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TaskHeader to golem-messages #3655

Merged
merged 23 commits into from Dec 17, 2018

Conversation

Projects
None yet
4 participants
@jiivan
Copy link
Contributor

jiivan commented Dec 7, 2018

@jiivan jiivan requested a review from shadeofblue Dec 7, 2018

@wafflebot wafflebot bot added the in progress label Dec 7, 2018

jiivan added some commits Dec 7, 2018

@etam
Copy link
Contributor

etam left a comment

Why are you changing all timeouts from ints to floats?

Show resolved Hide resolved apps/core/task/coretask.py Outdated

jiivan added some commits Dec 12, 2018

Show resolved Hide resolved apps/rendering/task/renderingtaskstate.py Outdated

@etam etam referenced this pull request Dec 12, 2018

Merged

TaskHeader and friends #285

jiivan added some commits Dec 12, 2018

@etam

etam approved these changes Dec 17, 2018

Copy link
Contributor

etam left a comment

ok

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 17, 2018

Codecov Report

Merging #3655 into develop will decrease coverage by 0.17%.
The diff coverage is 96.34%.

@@             Coverage Diff             @@
##           develop    #3655      +/-   ##
===========================================
- Coverage    89.68%   89.51%   -0.18%     
===========================================
  Files          195      193       -2     
  Lines        17538    17253     -285     
===========================================
- Hits         15729    15444     -285     
  Misses        1809     1809

jiivan added some commits Dec 17, 2018

jiivan added some commits Dec 17, 2018

@jiivan jiivan merged commit 3a3e5a0 into develop Dec 17, 2018

5 checks passed

buildbot/control_build Build done.
Details
buildbot/control_test Build done.
Details
codecov/patch 96.34% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -0.17% but relative coverage increased by +6.65% compared to c9f13a0
Details
license/cla Contributor License Agreement is signed.
Details

@wafflebot wafflebot bot removed the in progress label Dec 17, 2018

@jiivan jiivan deleted the task_header branch Dec 17, 2018

@prekucki

This comment has been minimized.

Copy link
Contributor

prekucki commented Dec 17, 2018

$ golemcli network show
Exception: success return value from invoked procedure \"net.peers.connected\" could not be serialized: WAMP message serialization error: unsupported type: <class 'golem_messages.datastructures.p2p.Node'>

@jiivan

This comment has been minimized.

Copy link
Contributor Author

jiivan commented Dec 17, 2018

$ golemcli network show
Exception: success return value from invoked procedure "net.peers.connected" could not be serialized: WAMP message serialization error: unsupported type: <class 'golem_messages.datastructures.p2p.Node'>

#3676

etam added a commit that referenced this pull request Dec 18, 2018

cleanup remaining fixed_header
this is a leftover of #3655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.