Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminal colors #1

Closed
wants to merge 1 commit into from
Closed

Update terminal colors #1

wants to merge 1 commit into from

Conversation

aarowill
Copy link

Fix terminal colors in default color scheme according to https://github.com/chriskempson/base16-xresources (and the rest of the terminal color scheme repos).
Add 256 color scheme template that doesn't make bright colors behave unexpectedly according to https://github.com/chriskempson/base16-shell.

Fix terminal colors in default color scheme
Add 256 color scheme template that doesn't make bright colors behave
unexpectedly
@golf1052
Copy link
Member

golf1052 commented Nov 19, 2019

Thanks for the CR and pointing to the base16-shell repo. I've updated the standard colors to match what you had (which also matches the base16-shell repo). I however am not going to take the bright colors as they are different than what base16-shell recommends. I've pasted images below showing the difference. Also VSCode currently doesn't support theming for 256 or 24-bit colors, only 4-bit, see here, so I will not add the 256.json output either.

Your colors

image

image

Suggested colors

image

image

VSCode Dark+ colors

image

image

@golf1052 golf1052 closed this Nov 19, 2019
golf1052 added a commit to golf1052/base16-generator that referenced this pull request Nov 19, 2019
golf1052 added a commit that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants