Dependency issue with Gollum 2.4.1 and Rails 3.0.20 #647

Closed
andrerpbts opened this Issue Mar 7, 2013 · 20 comments

Comments

Projects
None yet
5 participants

I'm using gollum 2.2.1 in a rails 3.0.20 application, but only the gollum object in my own Rails controllers, instead of Sinatra. It's working fine, but, now I want to upgrade Gollum to version 2.4.1 and I'm getting rack dependency issue. Like:

Bundler could not find compatible versions for gem "rack":
  In Gemfile:
    gollum (= 2.4.1) ruby depends on
      rack (>= 1.3.6, ~> 1.3) ruby

    rails (= 3.0.20) ruby depends on
      rack (1.2.8)

Since I'm not using Sinatra here, Am I wrong to think this issue is unnecessary? There's a solution?

Wouldn't be good if the Gollum Server was a separated gem that uses Gollum object?

Member

dekimsey commented Mar 7, 2013

This isn't a bad idea. Having gollum vs gollum-lib, since the expected
behavior would be the entire app seeing as that is how it has been
distributed for some time now.
On Mar 7, 2013 8:02 AM, "André Rodrigues" notifications@github.com wrote:

I'm using gollum 2.2.1 in a rails 3.0.20 application, but only the gollum
object in my own Rails controllers, instead of Sinatra. It's working fine,
but, now I want to upgrade Gollum to version 2.4.1 and I'm getting rack
dependency issue. Like:

Bundler could not find compatible versions for gem "rack":
In Gemfile:
gollum (= 2.4.1) ruby depends on
rack (>= 1.3.6, ~> 1.3) ruby

rails (= 3.0.20) ruby depends on
  rack (1.2.8)

Since I'm not using Sinatra here, Am I wrong to think this issue is
unnecessary? There's a solution?

Wouldn't be good if the Gollum Server was a separated gem that uses Gollum
object?


Reply to this email directly or view it on GitHubhttps://github.com/github/gollum/issues/647
.

Member

jamieoliver commented Mar 7, 2013

+1

Owner

bootstraponline commented Mar 7, 2013

I agree this makes sense.

Member

jamieoliver commented Mar 9, 2013

I had a quick look at this yesterday and it should be reasonably straightforward. As far as I can see there is just one easily resolved dependency that the back end currently has on the front end code. Most of the work involved would be as follows:

  • decide what to call the new gem
  • create/fork a new repo containing back end code while maintaining the history
  • build the initial version of the back end gem
  • remove back end code from github/gollum and add the new gem as a dependency
  • move any issues if necessary
Owner

bootstraponline commented Mar 9, 2013

decide what to call the new gem

I think @dekimsey's suggestion of gollum-lib is good.

create/fork a new repo containing back end code while maintaining the history

Ideally this would be in github/gollum-lib. I can't create new repos for GitHub though. /cc @atmos

build the initial version of the back end gem

It'd be nice if gollum-lib used the existing Rakefile for easy releasing.

move any issues if necessary

The issues may be easier to keep on gollum. Migrating issues across repos on GitHub is a pain. It's also less work for end users, they don't have to decide to file against gollum vs gollum-lib. Tagging issues as gollum-lib may be good enough.

Member

jamieoliver commented Mar 13, 2013

I've committed an initial attempt at gollum-lib to jamieoliver/gollum/feature/gollum-lib/initial/gollum-lib. Comments would be appreciated. I'll take a look at removing the back end stuff from gollum soon as well.

Owner

bootstraponline commented Mar 15, 2013

@jamieoliver I made gollum/gollum-lib and you should have push access.

jamieoliver pushed a commit to gollum/gollum-lib that referenced this issue Mar 15, 2013

Member

jamieoliver commented Mar 15, 2013

I've pushed to gollum-lib. Some things still need to be done such as sort out the documentation and Travis/Gemnasium stuff. Still working on the front end changes.

Owner

bootstraponline commented Mar 15, 2013

gollum-lib will probably need a new Travis and Gemnasium badge.

Member

jamieoliver commented Mar 16, 2013

Agreed. @bootstraponline, you'll need to set up the Travis and Gemnasium hooks as I don't have access to the repo settings. Also do you think it makes sense to start logging issues against gollum-lib? I think we need one issue for the hooks and one for documentation.

Owner

bootstraponline commented Mar 16, 2013

Also do you think it makes sense to start logging issues against gollum-lib?

Yes. I'm not sure it makes sense to migrate all the old issues though.

I updated Travis and Gemnasium for gollum-lib so they should work now.

Member

jamieoliver commented Mar 17, 2013

Thanks. I agree that it makes sense to keep existing issues where they are and also keep gollum as the default place to log issues unless they are known to be specific to gollum-lib.

jamieoliver pushed a commit to jamieoliver/gollum that referenced this issue Mar 19, 2013

Member

jamieoliver commented Mar 20, 2013

The code is basically ready, but doesn't have the very latest changes (#660, #661) merged. Are there any more changes expected imminently? I'm thinking it would be good to get the initial version of gollum-lib built so we can get the pull request merged.

Owner

bootstraponline commented Mar 20, 2013

Are there any more changes expected imminently?

Not that I know of.

I'm thinking it would be good to get the initial version of gollum-lib built so we can get the pull request merged.

I agree. I'll try to build and push the gollum-lib gem to rubygems.

Owner

bootstraponline commented Mar 20, 2013

gollum-lib is up.

Member

jamieoliver commented Mar 20, 2013

Great, thanks. #660 and #661 are now merged and the pull request is green. I still need to merge those changes to gollum-lib (which I will do later today) but that doesn't affect this.

Member

jamieoliver commented Mar 20, 2013

#660 and #661 have now also been merged to gollum-lib.

bootstraponline added a commit that referenced this issue Mar 20, 2013

Owner

bootstraponline commented Mar 20, 2013

#664 is merged. Using the gollum-lib gem instead of gollum should resolve this issue.

Contributor

cpence commented Mar 22, 2013

The gemspec manifest needs to be updated; it now refers to all sorts of files that no longer exist in gollum proper.

Owner

bootstraponline commented Mar 22, 2013

The gemspec manifest needs to be updated

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment