.netrc support with helm deploy #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
======================================
Coverage 45.7% 45.7%
======================================
Files 89 89
Lines 2890 2890
======================================
Hits 1321 1321
Misses 1456 1456
Partials 113 113Continue to review full report at Codecov.
|
michalpristas
approved these changes
Oct 3, 2018
arschles
previously requested changes
Oct 3, 2018
There was a problem hiding this comment.
@fedepaol thanks for this! it looks great to me. Can you add the \n that @michalpristas commented on, and then we can merge?
|
@arschles |
ghost
dismissed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #721 by having the .netrc imported as k8s secret and passed to athens.