Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Float64Map #605

Merged
merged 3 commits into from Mar 24, 2022
Merged

feat: add Float64Map #605

merged 3 commits into from Mar 24, 2022

Conversation

zuoshuwen
Copy link
Contributor

@zuoshuwen zuoshuwen commented Mar 24, 2022

add Float64Map()

Copy link
Collaborator

@stevenh stevenh left a comment

Thanks for PR @zuoshuwen just a minor niggle, could you move this new method down to where the other map methods are, say after Int64Map around line 508 so that they are all together :)

@zuoshuwen
Copy link
Contributor Author

zuoshuwen commented Mar 24, 2022

Hey @stevenh , thanks for your advice

Copy link
Collaborator

@stevenh stevenh left a comment

Sorry I missed a typo

redis/reply.go Outdated Show resolved Hide resolved
Co-authored-by: Steven Hartland <steven.hartland@multiplay.co.uk>
@zuoshuwen zuoshuwen requested a review from stevenh Mar 24, 2022
@stevenh stevenh merged commit dbebed5 into gomodule:master Mar 24, 2022
@zuoshuwen
Copy link
Contributor Author

zuoshuwen commented Mar 24, 2022

Thanks for taking this PR :)

@stevenh
Copy link
Collaborator

stevenh commented Mar 24, 2022

Thank you for the PR 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants