diff --git a/internal/asm/f64/ge_amd64.go b/internal/asm/f64/ge_amd64.go index db1a097b1..12dd3232b 100644 --- a/internal/asm/f64/ge_amd64.go +++ b/internal/asm/f64/ge_amd64.go @@ -12,7 +12,7 @@ package f64 func Ger(m, n uintptr, alpha float64, x []float64, incX uintptr, y []float64, incY uintptr, a []float64, lda uintptr) // GemvN computes -// y = alpha * a * x + beta * y +// y = alpha * A * x + beta * y // where A is an m×n dense matrix, x and y are vectors, and alpha and beta are scalars. func GemvN(m, n uintptr, alpha float64, a []float64, lda uintptr, x []float64, incX uintptr, beta float64, y []float64, incY uintptr) diff --git a/internal/asm/f64/ge_noasm.go b/internal/asm/f64/ge_noasm.go index 81989bcb6..d180ae85a 100644 --- a/internal/asm/f64/ge_noasm.go +++ b/internal/asm/f64/ge_noasm.go @@ -35,7 +35,7 @@ func Ger(m, n uintptr, alpha float64, x []float64, incX uintptr, y []float64, in } // GemvN computes -// y = alpha * a * x + beta * y +// y = alpha * A * x + beta * y // where A is an m×n dense matrix, x and y are vectors, and alpha and beta are scalars. func GemvN(m, n uintptr, alpha float64, a []float64, lda uintptr, x []float64, incX uintptr, beta float64, y []float64, incY uintptr) { var kx, ky, i uintptr diff --git a/internal/asm/f64/gemv_test.go b/internal/asm/f64/gemv_test.go index 507e01d74..96a3f74d0 100644 --- a/internal/asm/f64/gemv_test.go +++ b/internal/asm/f64/gemv_test.go @@ -10,21 +10,17 @@ import ( ) type DgemvCase struct { - m int - n int - A []float64 - x []float64 - y []float64 - xCopy []float64 - yCopy []float64 + m int + n int + A []float64 + x []float64 + y []float64 NoTrans []DgemvSubcase Trans []DgemvSubcase } type DgemvSubcase struct { - mulXNeg1 bool - mulYNeg1 bool alpha float64 beta float64 want []float64 @@ -511,13 +507,11 @@ func TestGemv(t *testing.T) { t.Run(fmt.Sprintf("(%vx%v)", test.m, test.n), func(tt *testing.T) { for i, cas := range test.NoTrans { tt.Run(fmt.Sprintf("NoTrans case %v", i), func(st *testing.T) { - // Test that it passes with row-major dgemvcomp(st, test, false, cas, i) }) } for i, cas := range test.Trans { tt.Run(fmt.Sprintf("Trans case %v", i), func(st *testing.T) { - // Test that it passes with row-major dgemvcomp(st, test, true, cas, i) }) }