-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
|
Better documentation and more checks coming. I'm not sure how to test this other than to rewrite the code again. However, this code will be called by a bunch of routines so it should be effectively tested then. |
|
Good news: Just added tests for Dlasr Suggestions? Log a bug with OpenBLAS, and comment out the tests I've added for that case. What about the dpocon script itself? It's generating random cases at present. |
This is not good, but it's not terrible. At least the issue is consistent and code that work elsewhere works just as well here.
I think so.
What do you mean? |
|
The added case arises when generating the random test cases (at least with the random number stream on my machine). In order to pass the tests this case shouldn't be generated. I could, for example, make the loop shorter, but that dousn't feel like the right solution. |
|
Maybe log cases >1e-14 and fail case >1e-2? |
|
Filed OpenMathLib/OpenBLAS#664 |
|
Implemented suggestions. |
native/dlasr.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs in LAPACK are very informative. Could this be expanded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
LGTM after test comment improved. I'll leave the doc comment up to you. |
testlapack/dgecon.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this here?
No description provided.