Add output for error handling #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds output for errors, previously it was `fmt.Sprintf` which will only format and doesn't output the string. The commit also provides more information about when the command isn't run in the git toplevel. This could be solved by using `git rev-parse --show-toplevel` but as far as I can tell, this isn't supported in go-git right now.
gitbr.go
Outdated
|
|
||
| if os.IsNotExist(err) { | ||
| return nil, fmt.Errorf("no .git directory detected (needs to be in repository toplevel).") | ||
| } |
There was a problem hiding this comment.
I think this is already covered by
git-br/vendor/gopkg.in/src-d/go-git.v4/repository.go
Lines 221 to 222 in 858332d
PlainOpen call so we don't need to do it twice.
There was a problem hiding this comment.
Ah, must have missed that. Thanks!
| os.Exit(1) | ||
| } | ||
|
|
||
| err = uiRunner.Run() | ||
| if err != nil { | ||
| fmt.Sprintf("Error: %s", err.Error()) | ||
| fmt.Printf("Error: %s\n", err.Error()) |
This removes a check that for the .git directory which is also done in go-git.
|
Merged! 👍 |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds output for errors, previously it was
fmt.Sprintfwhich will onlyformat and doesn't output the string.
The commit also provides more information about when the command isn't run in
the git toplevel. This could be solved by using
git rev-parse --show-toplevelbut as far as I can tell, this isn't supported in go-gitright now.
Super useful utility, thank you for creating this!