New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash when uri encoding pound sign #4

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
2 participants
@colinnewell

colinnewell commented Jul 18, 2017

This prevents a segfault when url encoding £.

Segmentation fault (Signal sent by the kernel)
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1/auto/HTTP/XSCookies/XSCookies.so(url_encode+0x40)[0x7f72271e7180]
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1/auto/HTTP/XSCookies/XSCookies.so(+0x33c1)[0x7f72271e63c1]
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1/auto/HTTP/XSCookies/XSCookies.so(cookie_put_string+0xe)[0x7f72271e64ae]
/usr/local/lib/x86_64-linux-gnu/perl/5.22.1/auto/HTTP/XSCookies/XSCookies.so(+0x2c2d)[0x7f72271e5c2d]
perl(Perl_pp_entersub+0x48a)[0x4bd3ca]
perl(Perl_runops_standard+0x16)[0x4b6276]
perl(perl_run+0x2f9)[0x443c59]
perl(main+0x12b)[0x41cbbb]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f7227d34830]
perl(_start+0x29)[0x41cbf9]
Segmentation fault (core dumped)

@gonzus gonzus merged commit 623ebf5 into gonzus:master Jul 18, 2017

@gonzus

This comment has been minimized.

Show comment
Hide comment
@gonzus

gonzus Jul 18, 2017

Owner

Thanks for that patch. I refactored it a bit (into a macro) and made sure the same logic was applied in two other places.
Tomorrow I will cut upload a new version to CPAN. Cheers!

Owner

gonzus commented Jul 18, 2017

Thanks for that patch. I refactored it a bit (into a macro) and made sure the same logic was applied in two other places.
Tomorrow I will cut upload a new version to CPAN. Cheers!

@colinnewell

This comment has been minimized.

Show comment
Hide comment
@colinnewell

colinnewell Jul 18, 2017

Thank you. That's perfect.

colinnewell commented Jul 18, 2017

Thank you. That's perfect.

@gonzus

This comment has been minimized.

Show comment
Hide comment
@gonzus

gonzus Jul 19, 2017

Owner

New version HTTP-XSCookies-0.000011 just uploaded to CPAN. It includes a fix for a very infrequent bug in one of the tests, so I expect now to see a full green scorecard... Here's hoping.

Owner

gonzus commented Jul 19, 2017

New version HTTP-XSCookies-0.000011 just uploaded to CPAN. It includes a fix for a very infrequent bug in one of the tests, so I expect now to see a full green scorecard... Here's hoping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment