Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] aliyun repo webhook name not match #218

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@lxm
Copy link
Contributor

lxm commented Aug 23, 2019

post data in aliyun repo webhook

{
    "push_data":{
        "digest":"sha256:xxxx",
        "pushed_at":"2019-08-23 20:14:58",
        "tag":"latest"
    },
    "repository":{
        "date_created":"2019-08-23 16:49:17",
        "name":"name",
        "namespace":"namespace",
        "region":"cn-zhangjiakou",
        "repo_authentication_type":"NO_CERTIFIED",
        "repo_full_name":"namespace/name",
        "repo_origin_type":"NO_CERTIFIED",
        "repo_type":"PRIVATE"
    }
}

There's not repo_name schema and there's no domain info in repo_full_name schema

As a result, the follow code

            repo_ref = reference.Reference.parse(repo_name)
            _, repo_name = repo_ref.split_hostname()

will change repo_name's value to "name" but not "namespace/name", then webhook will response a http 400 code with message "镜像名称与服务构建源不符"

@barnettZQG barnettZQG merged commit 8b237f9 into goodrain:master Aug 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@barnettZQG barnettZQG added this to the v5.1.7 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.