New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uranus on solarsystem sample is oriented horizontally instead of vertically #479

Open
kenkawakenkenke opened this Issue Dec 23, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@kenkawakenkenke
Copy link

kenkawakenkenke commented Dec 23, 2018

Expected: The axis of rotation of Uranus should be tilted 97.7° against the orbital axis (i.e the ring should look vertical) https://en.wikipedia.org/wiki/Uranus#Axial_tilt

Actual behaviour: Uranus is rendered with its rotational axis parallel to its orbital axis.
See screenshot: https://photos.app.goo.gl/HzeEs11KAqyrDoiQA

I realize this is just a sample app, but this really stands out in an otherwise beautiful app + feels like an easy enough fix.

kenkawakenkenke added a commit to kenkawakenkenke/sceneform-android-sdk that referenced this issue Dec 23, 2018

Fixes google-ar#479: sets tilt axis on Planet to allow rendering plan…
…ets (especially Uranus) more realistically.
@claywilkinson

This comment has been minimized.

Copy link
Member

claywilkinson commented Dec 27, 2018

Thanks @kenkawakenkenke for the pull request. Because of the way the SDK is published, it cannot be merged, but I've added it to the list of changes for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment