Fix RBC issues.#704
Merged
Merged
Conversation
- Update tensor capture/illegal move. - String observations now reflect tensor observations - Implement a forgotten rule that a pawn two-forward move can result in one-forward rule, if the one-forward would be otherwise legal. - Add a number of tests. - Add comments on what are the minor differences to the original rules.
VitamintK
approved these changes
Sep 14, 2021
Collaborator
Author
No worries, thanks for pointing out the problems you found! |
lanctot
added
the
imported
This was referenced Sep 20, 2021
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #695 #696 #679.
@VitamintK Thanks for raising these issues. Can you please help with reviewing the code, if you find any other rule inconsistencies?