Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure cred file is created with a predictable name #130

Merged
merged 1 commit into from Feb 3, 2022

Conversation

sethvargo
Copy link
Member

@sethvargo sethvargo commented Feb 3, 2022

Fixes #123

@sethvargo sethvargo requested a review from as a code owner Feb 3, 2022
@sethvargo sethvargo requested review from averikitsch (assigned from google-github-actions/maintainers) and bharathkkb (assigned from google-github-actions/maintainers) Feb 3, 2022
@sethvargo sethvargo force-pushed the sethvargo/predictable_path branch from e1e7b58 to 5323b36 Compare Feb 3, 2022
@sethvargo sethvargo enabled auto-merge (squash) Feb 3, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

LGTM and not related to this change but from the logs it looks like we were not building the action in CI and using the older distributable

- uses: 'actions/setup-node@v2'
with:
node-version: '16.x'
- id: 'auth-default'
name: 'auth-default'
uses: './'
with:
credentials_json: '${{ secrets.AUTH_SA_KEY_JSON }}'

src/utils.ts Show resolved Hide resolved
@sethvargo sethvargo force-pushed the sethvargo/predictable_path branch from 5323b36 to 975c0f3 Compare Feb 3, 2022
@sethvargo
Copy link
Member Author

@sethvargo sethvargo commented Feb 3, 2022

@bharathkkb fixed the build issue

@sethvargo sethvargo merged commit 48c46e6 into main Feb 3, 2022
9 checks passed
@sethvargo sethvargo deleted the sethvargo/predictable_path branch Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants