Skip to content

Fix tatoeba dataset branch name: master -> main #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

konstantinjdobler
Copy link

@konstantinjdobler konstantinjdobler commented Nov 20, 2021

It seems the repository for the tatoeba dataset (https://github.com/facebookresearch/LASER/) renamed their branch from master to main, which breaks the download_data.sh script. I fixed the issue #79 by renaming the branch in the download script as well.

@google-cla google-cla bot added the cla: no Contributor License Agreement has not been signed label Nov 20, 2021
@google-cla google-cla bot added cla: yes Contributor License Agreement has been signed and removed cla: no Contributor License Agreement has not been signed labels Nov 20, 2021
@sebastianruder sebastianruder added the Ready for Google PR has been reviewed and is ready to be merged label Nov 22, 2021
@sebastianruder
Copy link
Collaborator

Looks great. Thanks so much.

@sebastianruder sebastianruder merged commit c65565c into google-research:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Contributor License Agreement has been signed Ready for Google PR has been reviewed and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants