Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2.18.6 #11129

merged 23 commits into from Apr 19, 2023

r2.18.6 #11129

merged 23 commits into from Apr 19, 2023


Copy link

No description provided.

icbaker and others added 22 commits April 18, 2023 14:38
The `@CallSuper` annotation should help catch cases where subclasses are
calling `delegate.addListener` instead of `super.addListener` but it
will also (unintentionally) prevent subclasses from either completely
no-opping the listener registration, or implementing it themselves in a
very custom way. I think that's probably OK, since these cases are
probably unusual, and they should be able to suppress the warning/error.

Issue: androidx/media#258


PiperOrigin-RevId: 513848402
(cherry picked from commit af45bed)
Segment timelines are technically allowed to be empty, but not all places
add the necessary checks.

Issue: #11014
PiperOrigin-RevId: 514722205
(cherry picked from commit 0113174)
PiperOrigin-RevId: 517067549
(cherry picked from commit eb6fc93)

PiperOrigin-RevId: 517086016
(cherry picked from commit e4446c3)
PiperOrigin-RevId: 517128752
(cherry picked from commit d88dd74)
If RTSP Setup Request with UDP receives HTTP Error Status 461 UnsupportedTransport, then client will retry with TCP.

Issue: #11069
PiperOrigin-RevId: 518807829
(cherry picked from commit bbd45c8)
PiperOrigin-RevId: 518953648
(cherry picked from commit e811749)
When MediaCodecRenderer is given an empty sample stream, it puts
its output format change tracking in a bad state where we never
process future stream changes because we are waiting for a sample
that doesn't exist.

We can fix this by:
 - Looping the pending output stream changes to see if we processed
   more than one change at once (this fixes the tracking for empty
   sample streams that are not the first in the queue).
 - Checking if none of the previous streams queued any samples in
   onStreamChanged to handle this in the same way as the case
   where we already output all samples (this fixes the problem when
   the empty sample stream comes first in the queue).
 - Also calling onProcessedStreamChange for the case above, which
   was missing previously.


PiperOrigin-RevId: 519226637
(cherry picked from commit 652546c)
`DefaultDrmSession(Manager)` expect most of their methods to be called
on the 'playback thread'. There isn't a playback thread in the case of
`OfflineLicenseHelper`, but in that case it's the thread backing
`DefaultDrmSessionManager.playbackLooper`, which is `OfflineLicenseHelper.handlerThread`.

PiperOrigin-RevId: 520053006
(cherry picked from commit 2f7ba44)
PiperOrigin-RevId: 520314781
(cherry picked from commit 411fb9e)
The media3-hosted versions of these SVGs were removed due to a change in
the way the reference docs are generated. While work on getting them
hosted on, this change simply links to the
(identical) exoplayer2 versions in order to fix the media3 docs.


PiperOrigin-RevId: 520647905
(cherry picked from commit ddcae0b)
Issue: #11008
PiperOrigin-RevId: 520864579
(cherry picked from commit 1ac7f3c)
Change what format is logged from MediaCodecAudioRenderer when
AudioSink throws InitializationException. We printed the
AudioSink's format, which most of the times is audio/raw (PCM)
and not the renderer's format. With this change both formats are


Issue: #11066
PiperOrigin-RevId: 523456840
(cherry picked from commit 81d9c6c)

PiperOrigin-RevId: 523708424
(cherry picked from commit 96aa5bd)

PiperOrigin-RevId: 523959161
(cherry picked from commit e7727f4)

PiperOrigin-RevId: 523983688
(cherry picked from commit ded1206)
The overrides specified by a MediaController may not use the exact
same TrackGroup instances as known to the Player because the groups
have been bundled to and from the controller. This bundling may
alter the instance slightly depending on the version used on each
side of the communication and the fields set (e.g. Format.metadata
is not supported for bundling).

This issue can be solved by creating unique track group ids for
each group on the session side before bundling. On the way back,
the groups in the track selection parameters can be mapped backed
to their original instances based on this id.


Issue: androidx/media#296
PiperOrigin-RevId: 523986626
(cherry picked from commit 07707c2)
Dackka doesn't support `@value`

PiperOrigin-RevId: 524309695
(cherry picked from commit 9341290)
The sessions may have different application threads for their players,
and the service with its notification provider runs on the main thread.
To ensure everything runs on the correct thread, this change labels
methods where needed and fixes thread access in some places.

Issue: androidx/media#318
PiperOrigin-RevId: 524849598
(cherry picked from commit 73c216d)
PiperOrigin-RevId: 525168605
(cherry picked from commit 1c1603c)
PiperOrigin-RevId: 525176828
(cherry picked from commit 7d10596)

PiperOrigin-RevId: 525383571
(cherry picked from commit 4d97f49)
@rohitjoins rohitjoins self-assigned this Apr 19, 2023
PiperOrigin-RevId: 525415067
(cherry picked from commit 15d24ab)
@rohitjoins rohitjoins merged commit cf49175 into release-v2 Apr 19, 2023
1 check passed
@rohitjoins rohitjoins deleted the release-v2-r2.18.6 branch April 19, 2023 17:46
@google google locked and limited conversation to collaborators Jun 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

7 participants