implementation of a finite MPS class #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| """ | ||
| An MPS class for finite systems. | ||
| `FiniteMPS` keeps track of the nodes of the network by storing them in a list | ||
| `FiniteMPS._nodes`. Any external changes to this list will potentially corrupt |
There was a problem hiding this comment.
Don't mention private _node properties in the class description.
| Check orthonormality of tensor at site `site`. | ||
| Args: | ||
| which: if 'l' or 'left': check left orthogonality | ||
| if 'r' or'right': check right orthogonality |
There was a problem hiding this comment.
Add space after "or"
| from __future__ import division | ||
| from __future__ import print_function | ||
| import numpy as np | ||
| import tensornetwork as tn |
There was a problem hiding this comment.
Don't import tensornetwork directly. It can lead to circular import of we decided to make mps easier to access by putting it in tensornetwork/__init__.py file. Prefer to import everything you need directly.
chaserileyroberts
approved these changes
Oct 14, 2019
chaserileyroberts
suggested changes
Oct 14, 2019
|
removed the import |
chaserileyroberts
suggested changes
Oct 15, 2019
|
sorry, had forgotten about your earlier comments. Fixed this |
chaserileyroberts
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.