Jax backend #68
Merged
Jax backend #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 19, 2019 22:10
stavros11
approved these changes
May 22, 2019
There was a problem hiding this comment.
Not a JAX expert but looks good to me. Some small observations:
Because of the bug you mentioned, it requires the latest version of jax to work, but that's fine since this is already on their pip.
Also, there are still some rtol issues in the tests. Locally, sometimes they pass and sometimes I get some failures probably because we have random numbers without fixed seed. This is a jax issue though, since there are some numerical differences between jax and numpy dot for large matrices. I don't think this will be significant in any application.
|
Yeah that's a good observation. I think we should change those tests to be deterministic. Will do that in the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.