-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jax backend #68
Jax backend #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a JAX expert but looks good to me. Some small observations:
Because of the bug you mentioned, it requires the latest version of jax to work, but that's fine since this is already on their pip.
Also, there are still some rtol
issues in the tests. Locally, sometimes they pass and sometimes I get some failures probably because we have random numbers without fixed seed. This is a jax issue though, since there are some numerical differences between jax and numpy dot for large matrices. I don't think this will be significant in any application.
Yeah that's a good observation. I think we should change those tests to be deterministic. Will do that in the next PR. |
No description provided.