Navigation Menu

Skip to content

Commit

Permalink
Rearrange hidden columns in default WPA profile
Browse files Browse the repository at this point in the history
The Annotation, Thread Name, and Readying Process Name columns are off
by default but can be useful. There use is made easier if they appear in
a logical location when enabled. This change moves these columns. The
change was done by hand editing the .wpaProfile file, to avoid
introducing spurious changes. So, I now know that KeyColumnCount is what
determines how many columns (visible or not) are to the left of the
vertical orange bar. Good to know!

Note that Thread Name in the CPU Usage (Precise) tables is a poor choice
of names - it should be New Thread Name so that it sorts with New Thread
Id. This also avoids ambiguity - there are three threads involved in a
context switch so "Thread Name" doesn't actually mean anything.

I'm tempted to make Thread Name on by default - it works very well when
profiling Chrome, which makes use of the new Windows 10 thread naming
APIs.

This change also fixes a typo in a pair of print statements.
  • Loading branch information
randomascii committed May 4, 2018
1 parent 546ec0e commit da408ec
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions UIforETW/Utility.cpp
Expand Up @@ -105,10 +105,10 @@ void copyWPAProfileToLocalAppData(const std::wstring& exeDir, const bool force)
if (force) // Print status of copy
{
if (copyResult)
outputPrintf(L"%s", L"Copied Startup.10wpaProfile to %localappdata%\\Windows Performance Analyzer\n");
outputPrintf(L"%s", L"Copied Startup10.wpaProfile to %localappdata%\\Windows Performance Analyzer\n");
else
{
outputPrintf(L"%s", L"Failed to copy Startup.10wpaProfile to %localappdata%\\Windows Performance Analyzer\n");
outputPrintf(L"%s", L"Failed to copy Startup10.wpaProfile to %localappdata%\\Windows Performance Analyzer\n");
outputLastError();
}
}
Expand Down

0 comments on commit da408ec

Please sign in to comment.