PicassoImage doesn't scale correctly when Modifier.aspectRatio() is used

[alexjlockwood]

I have a sample app that I was working on for a blog post.

In the picasso-bug branch, I use a PicassoImage like this (link to code):

    PicassoImage(
        data = imageUrl,
        modifier = modifier.aspectRatio(16f / 9f),
        fadeIn = true,
        contentScale = ContentScale.Crop,
    )

I do not see this same behavior with CoilImage however. On the master branch, I am using this code:

    CoilImage(
        data = imageUrl,
        modifier = modifier.aspectRatio(16f / 9f),
        fadeIn = true,
        contentScale = ContentScale.Crop,
    )

[chrisbanes]

This is an interesting one.

So the issue is that I'm calling Picasso.get(...).resize(composableSize).onlyScaleDown(), which scales the bitmap to to fill the bounds (ignoring aspect ratio). This is very different to Coil's handling, which never changes the aspect ratio (much, much better imo).

Now, we two options: centerCrop() or centerInside(), and neither are perfect.

• centerCrop() is the right solution if you're using ContentScale.Crop (it does the same thing), but it breaks the other ContentScales.
• centerInside() maintains aspect ratio, but scales down. So images might be scaled smaller than the composable, and then scaled back up via the ContentScale which will look bad.
• Ideally I want a centerOutside(), which will scale the image so that both dimensions are >= requested bounds (i.e. it covers the bounds), similar to Coil's Scale.FILL

I think I'll have to go with the correct solution: centerInside().

[alexjlockwood]

thanks for the quick fix chris!