Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DrawablePainter] Fix reacting to intrinsic size changes #1124

Merged
merged 8 commits into from Jun 28, 2022

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Apr 8, 2022

Currently DrawablePainter has an invalidateTick which triggers a draw pass, but there is nothing to trigger a layout pass. This PR adds another tick for layout, which is triggered when the intrinsic size changes

Currently DrawablePainter has an `invalidateTick` which triggers a draw pass, but there is nothing to trigger a layout pass. This PR adds another tick for layout, which is triggered when the intrinsic size changes.
@chrisbanes chrisbanes changed the title Fix DrawablePainter not reacting to intrinsic size changes [DrawablePainter] Fix reacting to intrinsic size changes Apr 8, 2022
Copy link
Collaborator

@andkulikov andkulikov left a comment

Thanks!

@chrisbanes chrisbanes requested a review from andkulikov Apr 12, 2022
That will teach me for trying to do this via the web editor
@chrisbanes
Copy link
Contributor Author

chrisbanes commented Apr 13, 2022

Failed on API 22 only. Probably needs a CI re-run

@chrisbanes
Copy link
Contributor Author

chrisbanes commented Apr 14, 2022

Ready to merge!

@andkulikov
Copy link
Collaborator

andkulikov commented Apr 14, 2022

Sorry, but I left one more comment 2 days ago, you probably didn't notice it

@chrisbanes
Copy link
Contributor Author

chrisbanes commented Apr 21, 2022

Sorry, but I left one more comment 2 days ago, you probably didn't notice it

Woops. Replied.

@andkulikov
Copy link
Collaborator

andkulikov commented Apr 21, 2022

Sorry, but I left one more comment 2 days ago, you probably didn't notice it

Woops. Replied.

Replied again. Sorry for the back and forth, just trying to understand the issue more

chrisbanes and others added 3 commits Jun 14, 2022
@andkulikov andkulikov enabled auto-merge Jun 28, 2022
@andkulikov andkulikov merged commit 88200fa into google:main Jun 28, 2022
10 checks passed
@chrisbanes chrisbanes deleted the patch-2 branch Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants