Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placeholder] Fix outline cache in placeholder #1155

Merged
merged 1 commit into from May 23, 2022

Conversation

jeran
Copy link
Contributor

@jeran jeran commented May 7, 2022

In the original implementation of the placeholder modifier a lastOutline ref was used to cache the Outline returned by the drawPlaceholder method. An update was made that removed the assignment of the outline to the ref in this commit:

350f4b9#r62458837

This change restores the ref assignment to make the outline cache function correctly.

In the original implementation of the placeholder modifier a `lastOutline` ref was used to cache the `Outline` returned by the `drawPlaceholder` method. An update was made that removed the assignment of the outline to the ref in this commit:

google@350f4b9

This change restores the ref assignment to make the outline cache function correctly.
@google-cla
Copy link

google-cla bot commented May 7, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@bentrengrove bentrengrove self-requested a review May 23, 2022
Copy link
Collaborator

@bentrengrove bentrengrove left a comment

Thanks for the fix!

@bentrengrove bentrengrove enabled auto-merge May 23, 2022
@bentrengrove bentrengrove merged commit 2248e5e into google:main May 23, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants