Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pager] Fix Modifier.pagerTabIndicatorOffset() #1194

Merged
merged 3 commits into from Jun 10, 2022
Merged

Conversation

andkulikov
Copy link
Collaborator

@andkulikov andkulikov commented Jun 9, 2022

After pagerState.currentPage was changed to be updated once we scrolled half of the page the indicator offsets were broken.
I also removed unneeded use of composed modifier and page scrolls causing recomposition.

Please add the library name to the PR title. Example: "[Insets] Fixes typo"

andkulikov added 3 commits Jun 9, 2022
After pagerState.currentPage was changed to be updated once we scrolled half of the page the indicator offsets were broken.
I also removed unneeded use of composed modifier and page scrolls causing recomposition.
After pagerState.currentPage was changed to be updated once we scrolled half of the page the indicator offsets were broken.
I also removed unneeded use of composed modifier and page scrolls causing recomposition.
# Conflicts:
#	pager-indicators/src/androidTest/kotlin/com/google/accompanist/pager/TabIndicatorTest.kt
Copy link
Collaborator

@bentrengrove bentrengrove left a comment

Is there an attached issue to close?

@andkulikov
Copy link
Collaborator Author

andkulikov commented Jun 10, 2022

Is there an attached issue to close?
No, I just noticed this issue during my own testing

@andkulikov andkulikov merged commit 568be72 into google:main Jun 10, 2022
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants