Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Navigation Material] Mark transitionsInProgress complete in BottomSheetNavigator #1244

Merged
merged 2 commits into from Jul 13, 2022

Conversation

jbw0033
Copy link
Collaborator

@jbw0033 jbw0033 commented Jul 13, 2022

We should be marking markTransitionComplete on the
transitionsInProgress, not the backStack.

Fixes #978

We should be marking markTransitionComplete on the
transitionsInProgress, not the backStack.

Fixes google#978
@ianhanniballake ianhanniballake enabled auto-merge Jul 13, 2022
Make sure that the Navigator is attached before attempting to get its
state.
@ianhanniballake ianhanniballake merged commit 701b3d6 into google:main Jul 13, 2022
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] [ModalBottomSheet] ON_DESTROY NavBackStackEntry never triggered
2 participants