[Theme Adapter] Migrate all theme adapter libraries to Accompanist #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricknout
changed the title
ricknout
changed the title
sample/src/main/java/com/google/accompanist/sample/themeadapter/Material3Sample.kt
Outdated
Show resolved
Hide resolved
sample/src/main/java/com/google/accompanist/sample/themeadapter/MaterialSample.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Fonts are missing assets_licence
example: https://github.com/android/compose-samples/blob/main/JetLagged/ASSETS_LICENSE
.github/ISSUE_TEMPLATE/theme-adapter-material-bug-report copy.md
Outdated
Show resolved
Hide resolved
This was referenced Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates and merges all theme adapter libraries into Accompanist (source code, tests, docs, etc). There has also been a refactor to centralize all theme adapter logic into a core module, which is used by the AppCompat, Material, and Material 3 modules.
These libraries include:
com.google.accompanist:accompanist-appcompat-themetocom.google.accompanist:accompanist-themeadapter-appcompatcom.google.android.material:compose-theme-adaptertocom.google.accompanist:accompanist-themeadapter-materialcom.google.android.material:compose-theme-adapter-3tocom.google.accompanist:accompanist-themeadapter-material3com.google.android.material:compose-theme-adapter-coretocom.google.accompanist:accompanist-themeadapter-coreOnce merged, a follow-up PR will be made against the MDC-Android Compose Theme Adapter repository to deprecate those libraries in favor of these.