[SwipeRefresh] Add swipe up to refresh feature #541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make topSwipeRefreshState optional so the user will have the
choice to use topSwipeRefreshState, bottomSwipeRefreshState
or both.
- The bottom indicator wasn't following the user's gesture when
he swipes down. The indicators are supposed to follow the user
gesture until he stops swiping or the indicator reaches the
max offset
- Fix it by consumming the scroll in the `SwipeRefreshNestedScrollConnection`
- update the doc to take into account the parameters related
to the bottom SwipeRefreshIndicator
- change topSwipeRefreshState and bottomSwipeRefreshState
to topRefreshIndicatorState and bottomRefreshIndicatorState
- Change the Bottom position sample's activity title
- Create docsamples package and create docsamples/BidirectionalSwipeRefreshSample.kt file
- rename DocsSamples.kt to docsamples/SimpleSample.kt
- Add doc and code sample for bottom and bidirectional swipe refresh
- add demo video for bottom refresh indicator
|
Review needed |
chrisbanes
suggested changes
Jul 12, 2021
- update the APIs of SwipeRefresh and SwipeRefreshIndicator to accept one state
- use the positin parameter to specify the SwipeRefresh position
- update the SwipeRefreshIndicator api to accept a senseOfRotation
parameter
- Update the indicator alignment parameter to accept only
horizontal alignment.
chrisbanes
suggested changes
Jul 20, 2021
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/SwipeRefresh.kt
Outdated
Show resolved
Hide resolved
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/SwipeRefresh.kt
Outdated
Show resolved
Hide resolved
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/SwipeRefresh.kt
Outdated
Show resolved
Hide resolved
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/SwipeRefresh.kt
Outdated
Show resolved
Hide resolved
swiperefresh/src/main/java/com/google/accompanist/swiperefresh/CircularProgressPainter.kt
Outdated
Show resolved
Hide resolved
- reset the `SwipeRefresh` signature
- update test and docs
|
Some unresolved comments and conflicts. |
# Conflicts: # gradle/libs.versions.toml # swiperefresh/src/sharedTest/kotlin/com/google/accompanist/swiperefresh/SwipeRefreshTest.kt
- Add explicit android:exported="true" in AndroidManifest.xml for
Android 12 support (for activities SwipeRefreshBottomPositionSample
and BidirectionalSwipeRefreshSample
- Replace rememberGlidePainter by rememberImagePainter in
BidirectionalSwipeRefreshSample and SwipeRefreshBottomPositionSample
- Some tests had been removed while merging from the main brance (fixed
that).
- Replace 'SemanticsNodeInteraction.performGesture' (which is
deprecaded) by 'SemanticsNodeInteraction.performTouchInput'.
@JoseAlcerreca, I resolved them. |
sitatec
changed the title
|
|
|
Hi, is this going to be implemented? I would like to swipe up from the bottom. |
|
@phamsarah lt actually have been implemented since a year now, just not merged yet. If the maintainers will review and merge it, I will fix the conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the swipe to refresh bidirectional, as proposed in #516