Fix ANR when showing bottom sheets #680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
internalShow()
method could end up in an infinite loop sometimes (yay, recursion!). We now use the officialshow
API which should work. Unfortunately, ourshow
calls all get cancelled but Swipeable still settles in the closest state. This seems to always be the expanded/half-expanded state. We look at thesheetState
'stargetValue
in our try'sfinally
block to figure out if the state will settle in an expanded state and call theonSheetShown
callback based on that.I'm still investigating why the
show
calls are getting cancelled in the first place and am working on a test for the ANR as well but would like to merge the fix to not keep #660 waiting for too long.Fixes #660