[Navigation Material] Fix Bottom Sheet Fully Expanding #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kinda similar to #741 - we were calling
show
too early. That meant that theSwipeableState
/ModalBottomSheetState
'sanchors
wouldn't have been calculated properly yet. By default, a sheet will have two anchors:Hidden
andExpanded
. IfsheetHeight > containerHeight / 2
, the sheet should have aHalfExpanded
state. For that,ModalBottomSheetLayout
needs to know the sheet's height, making it two-pass. The effect we use toshow
the sheet got called on the first pass though, when the sheet content is composed to measure it, but the anchors didn't have the correct sheet height yet, causing the sheet to fully expand despite it being tall enough to have aHalfExpanded
state.This isn't a nice solution but in agreement with Matvei, it seems to be the most reasonable fix for the moment.