Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove markdown filter from pull request builds #790

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

alexvanyo
Copy link
Collaborator

Removes the **.md filter for pull-request PRs.

PRs can't be merged until all required checks pass, but a change to only documentation won't cause any checks to run, leading to a fun catch-22.

The simplest solution seems to be just removing this filter from pull-request PRs.

@JoseAlcerreca
Copy link
Collaborator

If the checks are filtered out they shouldn't appear as checks at all. We need to look into this but this LGTM for now, to unblock the PRs.

@JoseAlcerreca JoseAlcerreca merged commit db80e76 into main Oct 14, 2021
@JoseAlcerreca JoseAlcerreca deleted the av/remove-markdown-filter branch October 14, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants