From ef6ac3385dc34803cf28d65f36cbdaa79f27db71 Mon Sep 17 00:00:00 2001 From: Adrian Altermatt Date: Thu, 13 Nov 2025 11:02:28 +0100 Subject: [PATCH 1/2] Too many E(inv=2, role=user) plus reformatting Main change from: E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user), To: E(inv=2, role=user), E(inv=2, role=model) I think the last E(inv=2, role=user) was wrong. Also reformatted. --- src/google/adk/apps/compaction.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/src/google/adk/apps/compaction.py b/src/google/adk/apps/compaction.py index a6f55f9ad6..b4221f8833 100644 --- a/src/google/adk/apps/compaction.py +++ b/src/google/adk/apps/compaction.py @@ -72,9 +72,10 @@ async def _run_compaction_for_sliding_window( beginning. - A `CompactedEvent` is generated, summarizing events within `invocation_id` range [1, 2]. - - The session now contains: `[E(inv=1, role=user), E(inv=1, role=model), - E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user), - CompactedEvent(inv=[1, 2])]`. + - The session now contains: `[ + E(inv=1, role=user), E(inv=1, role=model), + E(inv=2, role=user), E(inv=2, role=model), + CompactedEvent(inv=[1, 2])]`. 2. **After `invocation_id` 3 events are added:** - No compaction happens yet, because only 1 new invocation (`inv=3`) @@ -91,10 +92,13 @@ async def _run_compaction_for_sliding_window( - The new compaction range is from `invocation_id` 2 to 4. - A new `CompactedEvent` is generated, summarizing events within `invocation_id` range [2, 4]. - - The session now contains: `[E(inv=1, role=user), E(inv=1, role=model), - E(inv=2, role=user), E(inv=2, role=model), E(inv=2, role=user), - CompactedEvent(inv=[1, 2]), E(inv=3, role=user), E(inv=3, role=model), - E(inv=4, role=user), E(inv=4, role=model), CompactedEvent(inv=[2, 4])]`. + - The session now contains: `[ + E(inv=1, role=user), E(inv=1, role=model), + E(inv=2, role=user), E(inv=2, role=model), + CompactedEvent(inv=[1, 2]), + E(inv=3, role=user), E(inv=3, role=model), + E(inv=4, role=user), E(inv=4, role=model), + CompactedEvent(inv=[2, 4])]`. Args: From 627b933bdc3e00e45f704edf95448281e32d127c Mon Sep 17 00:00:00 2001 From: Adrian Altermatt Date: Fri, 14 Nov 2025 10:09:16 +0100 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- src/google/adk/apps/compaction.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/google/adk/apps/compaction.py b/src/google/adk/apps/compaction.py index b4221f8833..4511b1b96e 100644 --- a/src/google/adk/apps/compaction.py +++ b/src/google/adk/apps/compaction.py @@ -74,7 +74,7 @@ async def _run_compaction_for_sliding_window( `invocation_id` range [1, 2]. - The session now contains: `[ E(inv=1, role=user), E(inv=1, role=model), - E(inv=2, role=user), E(inv=2, role=model), + E(inv=2, role=user), E(inv=2, role=model), CompactedEvent(inv=[1, 2])]`. 2. **After `invocation_id` 3 events are added:** @@ -95,9 +95,9 @@ async def _run_compaction_for_sliding_window( - The session now contains: `[ E(inv=1, role=user), E(inv=1, role=model), E(inv=2, role=user), E(inv=2, role=model), - CompactedEvent(inv=[1, 2]), + CompactedEvent(inv=[1, 2]), E(inv=3, role=user), E(inv=3, role=model), - E(inv=4, role=user), E(inv=4, role=model), + E(inv=4, role=user), E(inv=4, role=model), CompactedEvent(inv=[2, 4])]`.