Skip to content

fix: exclude temp: state keys from Firestore session writes #5841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tinnitussen wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix: exclude temp: state keys from Firestore session writes #5841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/google/adk/integrations/firestore/firestore_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,7 @@ async def _append_txn(transaction: firestore.AsyncTransaction) -> int:
for k, v in session.state.items()
if not k.startswith(State.APP_PREFIX)
and not k.startswith(State.USER_PREFIX)
and not k.startswith(State.TEMP_PREFIX)
}
transaction.update(
session_ref,
Expand Down
9 changes: 9 additions & 0 deletions tests/unittests/integrations/firestore/test_firestore_session_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,15 @@ async def test_append_event_with_temp_state(mock_firestore_client):
assert "temp:k1" not in event_data["actions"]["state_delta"]
assert event_data["actions"]["state_delta"]["session_key"] == "session_val"

# 3. Verify temp keys are NOT written to session state in Firestore
transaction.update.assert_called_once()
update_args, _ = transaction.update.call_args
persisted_state = update_args[1]["state"]
assert "temp:k1" not in persisted_state, (
"temp: keys must not be persisted to Firestore session state"
)
assert "session_key" in persisted_state


@pytest.mark.asyncio
async def test_list_sessions_with_user_id(mock_firestore_client):
Expand Down