New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows bug fixes. #49

Merged
merged 1 commit into from Dec 29, 2017

Conversation

Projects
None yet
1 participant
@scudette
Contributor

scudette commented Dec 29, 2017

  • DataStore.Set() was changed to maintain multiple type
    attributes (to support aff4:Image simultaneously with
    aff4:ImageStream etc) but this just breaks other attributes. Now
    DataStore.Set() can specify if other attributes should be cleared. It
    really only makes sense to have the replace parameter. This only
    makes sense for AFF4_TYPE.

  • Fixed a bug with compressed/uncompressed chunks. AFF4 specifies
    that chunks which do not compress well should be written
    uncompressed.

  • More logging conversion.

Windows bug fixes.
 * DataStore.Set() was changed to maintain multiple type
 attributes (to support aff4:Image simultaneously with
 aff4:ImageStream etc) but this just breaks other attributes. Now
 DataStore.Set() can specify if other attributes should be cleared. It
 really only makes sense to have the replace parameter. This only
 makes sense for AFF4_TYPE.

 * Fixed a bug with compressed/uncompressed chunks. AFF4 specifies
 that chunks which do not compress well should be written
 uncompressed.

 * More logging conversion.

@scudette scudette merged commit cd6d3ea into google:master Dec 29, 2017

@scudette scudette deleted the scudette:windows branch Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment